fix: remove forceful normalization of YAML to JSON #1044
Conversation
aeworxet
requested review from
magicmatatjahu,
jonaslagoni,
smoya and
asyncapi-bot-eve
as code owners
🦋 Changeset detectedLatest commit: dc621f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
aeworxet
force-pushed
the
fix-remove-forceful-normalization-of-yaml-to-json
branch
from
e8aaf2c to
087a11f
Compare
|
@asyncapi/bounty_team |
|
@aeworxet it would be worth adding a comment in https://github.com/asyncapi/parser-js/blob/master/packages/parser/src/validate.ts#L49 mentioning Spectral uses the https://github.com/stoplightio/yaml parser, and basically, JSON is a valid YAML doc, so no matters if you pass YAML or JSON, that YAML parser will be able to parse it. Additionally, please add two new unit tests in for the validate method testing at least one string input for JSON and another for YAML. |
|
Updated PR. |
|
Credits for the pack of changes in |
|
|
/rtm |
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This PR removes forceful normalization of YAML files to JSON format to fix #936, which in its turn lays the foundation for reporting correct
rangevalues in error diagnostics for YAML files inStudio.Related to #1012